<f00b4r0>
nbd: cool thanks. I'll *try* to update the test location tomorrow but I'm really under water right now, *sigh*
fakuivan has quit [Remote host closed the connection]
fakuivan has joined #openwrt-devel
madwoota has quit [Remote host closed the connection]
n3ph has quit [Ping timeout: 480 seconds]
madwoota has joined #openwrt-devel
robimarko has quit [Remote host closed the connection]
madwoota has quit [Remote host closed the connection]
madwoota has joined #openwrt-devel
plappermaul has quit [Quit: Page closed]
sorinello has quit [Ping timeout: 480 seconds]
Slimey has quit [Read error: Connection reset by peer]
Slimey has joined #openwrt-devel
pizzaman has joined #openwrt-devel
<pizzaman>
hello, I was wondering what the requirements are to get "new" model support added to OpenWRT. This question arises from a simple patch that I found someone else made (https://github.com/openwrt-xiaomi/openwrt/commit/81bfbed6eefb29ba35499ae09bf80d13ae2496b1) that "supports" my device ASUS RT-AX1800S (v2). I put supports in quotes b/c while network switching works, the WAN port is not functional (so
n3ph has joined #openwrt-devel
<Rondom>
pizzaman: The link you posted is not a link to the OpenWrt repo
Borromini has joined #openwrt-devel
<Rondom>
if you manage to fix it, maybe you can submit a PR to add it to OpenWrt ;-)
<slh>
pizzaman: in general it 'just' needs someone to step up and propose a working pull request on github (or via mail to the mailing list), what working means is up to discussion, but at least the wired ports generally should work
<slh>
pizzaman: obviously the PR will be reviewed, so be prepared to react to comments and do changes accordingly, some patience and persistence will be needed
<pizzaman>
<Rondom>: yeah I know it's not to openwrt. The "owner" of that repo put this together, and their patch (the link I posted) results in a mostly working device.
<pizzaman>
modulo the WAN port not receiving any ethernet frames... so it's not quite working I guess
<Rondom>
most device support pull requests come from one person owning and using that device
<Rondom>
people scratching their own itch so to say
<pizzaman>
even if the code to support it comes from someone else?
<pizzaman>
it's only a new dts file and a few configuration file changes, so no actual code in there. I think I should be able to "answer" questions (famous last words, I know)
<Rondom>
you give credit where credit is due of course
<pizzaman>
ofc
<Rondom>
but sometimes one person gives up and another person picks it up a year later or so. There are some device support PRs where that is the case
<pizzaman>
so, is there a way to indicate that this only works partially? (i.e., no WAN port)?
<Rondom>
I have not looked at the details, but ideally we would get the WAN port working I think
<slh>
the problem with that PR would be that it's not signed off by original author, so you can't just take it without that
<Rondom>
true
<Rondom>
contacting that author might be a good idea then
<slh>
the good news, remittor is kind of active on the forum, so you might be able to talk to him
<pizzaman>
ok, we'll reach out to that person and encourage them to send a PR
<pizzaman>
re remittor that's exactly what I was thinking. well tbh, I was wondering why they didn't yet submit a PR for the many devices that sem to be supported by their build system
<slh>
keep in mind, technical aspects can be fixed, copyright question can't (unless the original author actively cooperates), so those must be 101% correct
<pizzaman>
slh: hence my question above ;-)
<pizzaman>
One has to wonder whether a dts file is copyrightable. It's not that one can express the location of e.g., MMIO registers in a different ways (if we discount different representations of the same numeric value)?
<slh>
DTS itself is debatable, but I don't think anyone would want to take a legal discourse about that (so it's easier to reject, than to discuss legalese)
<slh>
the good part, the DTS is explicitly declared as // SPDX-License-Identifier: (GPL-2.0 OR MIT), but it still needs to be signed off
<pizzaman>
yeah, IANAL so I would not know anyways. I registerd for a forum account and will try to bug remittor
<pizzaman>
thanks for your patient help, I'd love to get this model supported by openwrt
<slh>
I just approved your account
<pizzaman>
thanks, let's see what remittor says
minimal has quit [Quit: Leaving]
n3ph has quit [Ping timeout: 480 seconds]
n3ph has joined #openwrt-devel
danitool has quit [Quit: Cubum autem in duos cubos, aut quadratoquadratum in duos quadratoquadratos]