<dlan>
still require some work to cleanup/refactor, but should be good to try..
hentai has joined #linux-sunxi
radxanaoki has quit [Quit: radxanaoki]
<apritzel>
dlan: ah nice, thanks, will have a look later
<apritzel>
smaeul_: could you repeat your Code-Owner-Review+1 on the TF-A patch I updated? I did some cosmetic change, and gerrit dropped your vote :-( At least the CI passed this time!
gsz has joined #linux-sunxi
smaeul_ has quit []
smaeul has joined #linux-sunxi
<apritzel>
wens: what's your plan for the 6.18 pull request? Towards the end of the week or earlier?
<wens>
apritzel: might try to wait for the gmac200
<wens>
hard to tell
<wens>
I'm always open to sending a second PR
<apritzel>
are there any open reviews? Lost a bit track of all the series ...
<wens>
I think all the series not yet merged all have some comments already
<Jookia>
should i voice my concerns with the patch?
<apritzel>
sure, why not?
<Jookia>
i dunno i voiced them earlier and got a little shut down? idk
<Jookia>
i'm not good at communicating
<Jookia>
i come off as a jerk i think
<apritzel>
main thing is you do it on the list, so it's in one place and archived
<Jookia>
okay
<Jookia>
apritzel: is it appropriate to offer a reviewed-by and then optional review stuff?
<Jookia>
i don't want to block my reviewed-by on things that are nice to have
<apritzel>
Jookia: yes, you can nitpick and then say: "Regardless: Reviewed-by: ...". Though I am more interested in a Tested-by:
<apritzel>
lschmid: just found your email from July to the list: please CC: the linux-sunxi list (and maybe the maintainers), that is more likely to reach the right people
<apritzel>
Jookia: looks like the byte order is not right? grouped like this it should read 93406000?
Net147 has joined #linux-sunxi
<Jookia>
this is what hexdump -C gave me
<Jookia>
should i be giving little endian 32-bit values? i guess that makes sense
<apritzel>
yes, hexdump -C gives you 00 06 40 93, but with spaces, so they are individual bytes, as found in memory. Without spaces I'd expect a (32-bit) hex value
Net147 has quit []
Net147 has joined #linux-sunxi
<Jookia>
apritzel: fixed :)
<apritzel>
thanks!
<Jookia>
oh, i also replied to the patch
<Jookia>
i tried to as polite as possible but i'm not really good at communicating so i assume it may have come off as pedantic or something
<wens>
I think it looks fine :)
<Jookia>
yay
BroderTuck has joined #linux-sunxi
<BroderTuck>
Jookia: You might need to do one more edit to the SID page. Looks like you managed to add an extra copy of your D1 value in the V3s section
<Jookia>
oh thanks for catching that. wow, i am not good at this
<Jookia>
fixed
<Jookia>
thanks so much
Schimsalabim has quit [Read error: Connection reset by peer]
Schimsalabim has joined #linux-sunxi
apritzel has quit [Ping timeout: 480 seconds]
BroderTuck has quit [Quit: Leaving]
<lschmid>
apritzel: Regarding the mail from July. Is it the one about I2C3? If so that has been resolved already on the irc here. If it's a different one help me out here, i might have forgotten myself...
<lschmid>
apritzel: Also, if I change the patch now to change the u32 into a uint32_t and add some info about where I got the data, do I get to still add the reviewed-by and tested-by or do I wait for the responses to the new patch?
<Jookia>
lschmid: you're fine to keep my tested-by/reviewed-by i think if it's not changing anything logical
<Jookia>
i can put them there if you give me hexdumps if you don't want to do the wiki work
<lschmid>
yeah i was about to ask about that. I can add them to the wiki no problem, I have added my SoM and other V3s based board there myself. But I have like 50-ish T113-S3 and one -S4 device here. Do we want all or some?
<Jookia>
wow, 50? :D
<lschmid>
Yes, tends to happen if you build and sell the modules ^^
<Jookia>
i'm not sure, i put 3 because those are the ones i had. i guess you could be scientific and sample a specific selection based on which lots you got, but i'd say just a few and the -S4
<Jookia>
or just 1 of -S3 and -S4
<Jookia>
it's probably not too important unless it's different to what i posted
<lschmid>
I see. But also the list is somewhat about finding a pattern in there maybe, so more of the same lot might be helpful... idk
<Jookia>
i wouldn't think too much about it. i really do wonder where that awboot t113-s4 chipid came from
<Jookia>
i do wonder if it's worth adding to your patch just in case? i'm not sure
<lschmid>
well according to the sunxi wiki there are multiple -S4 types but with maybe different ram yet again
<lschmid>
or rather the "s4p" variant
<Jookia>
from what i've read after looking at the differences in awboot and BSP and all kinds of things, i think this is the only quirk needed for that chipid/the t113s4. but i'm not sure. it might be best to wait until someone comes and complains
<lschmid>
I just had a look. All my -S3 start with the same 93406000
<Jookia>
the other thing that's probably in the chipid somewhere is speed binning for dvfs
<Jookia>
but i think that's kind of understood
<lschmid>
Ok then. I guess I'll leave the patch as it is and send it out if thats okay. I don't know if I'll get to it anytime soon otherwise
<Jookia>
that's all good to me, i'm not a maintainer i just hang around here :)
<lschmid>
I gathered that much, but I also just wanted to hear it from someone else ;)
<apritzel>
lschmid: I don't think we need all 50 SID values ;-)
<apritzel>
but maybe you can check for the second and third word, and see if there is any pattern
tlwoerner has joined #linux-sunxi
tlwoerner_ has quit [Ping timeout: 480 seconds]
wingrime1 has joined #linux-sunxi
wingrime-ww has quit [Ping timeout: 480 seconds]
<apritzel>
lschmid: oh, and yes, it's customary to carry over tags, unless you are doing relevant changes. And in this case Jookia gave you those tags despite having comments, so that's surely fine
aggi_ has joined #linux-sunxi
aggi has quit [Ping timeout: 480 seconds]
Asara_ has joined #linux-sunxi
Asara has quit [Ping timeout: 480 seconds]
Schimsalabim has quit [Read error: Connection reset by peer]
Schimsalabim has joined #linux-sunxi
hentai has quit [Remote host closed the connection]