03:38 <juanesf91> [PATCH v2 13/20] sunxi: A523: add DRAM initialisation routine.

03:38 <juanesf91> +u8 reserved_0x058[8];/* 0x05c */

03:38 <juanesf91> apritzel: In the series sent for u-boot

03:38 <juanesf91> the reg and description/detail do not match

04:16 <junari> BroderTuck: My walnutpi is an engineering sample that was given to me by the founder when I was in china. It has the SDIO module from quectel, but I think it is all reference implementation

04:16 <junari> *SDIO module from quectel, also using the aic8800

10:14 <tokyovigilante> loki666: paulk: thanks again, had the port/endpoint enumerations confused. Now have a TCON configuration that makes the DT bindings happy and display working on the RG35XX. Last issue before I submit is the backlight without a PWM driver. I'm loathe to submit this series without some sort of backlight support, but the PWM driver doesn't seem to be close to merging. Is it ok to submit with the PIN just modelled as a GPIO

10:14 <tokyovigilante> (ie on/off or 100% duty cycle) or should I just remove it and submit the LCD patches without the PWM pin?

10:16 <loki666> tokyovigilante: from a end user POV, GPIO is better than a black screen

10:17 <loki666> We can change that when (if) PWM serie is applied

10:23 <tokyovigilante> loki666: agreed, however apritzel had a concern on the previous series about adding it prematurely. I can see both sides, and it's not a big deal to manually add the GPIO control in the meantime. That only affects the LCD on the RG devices, not the DE/TCON support for the H616 more generally. It makes sense to add the pin itself to the H616 DTS, how it is driven is for the individual device to decide.

10:29 <loki666> True, I remember reading that DTS shouldn't match with whatever the drivers expect to works, but only describe the hardware... So yes this pin should be configured as a PWM and the backlight should be a pwm-backlight

10:31 <tokyovigilante> the pin only needs to be described as part of the GPIO bank in the H616 DTS, the RGxxXX DTSes can configure it as a GPIO switched or PWM backlight, so I think the debate is just whether it goes in the device DTS. either way not a big deal to add manually downstream or change when the PWM driver lands.

10:34 <tokyovigilante> current code is staged here currently in any case - https://git.sr.ht/~tokyovigilante/linux/log/anbernic-display-mainline-v4-v2

10:34 <tokyovigilante> will send a patch tomorrow if no more feedback here, functionally no real changes, just as minimal as can be now.

10:42 <apritzel> tokyovigilante: leave it out of the post, and paper over it downstream for now. You could even think of turning the GPIO on in U-Boot for instance, then it would even work with pure mainline

20:24 <tokyovigilante> apritzel: thanks, will do