Nasina has quit [Read error: Connection reset by peer]
Nasina has joined #dri-devel
smpl has quit [Ping timeout: 480 seconds]
<mareko>
karolherbst: that's because rusticl uses compute queues and ac_prepare_compute_blit fails with that format because compute blits can't copy it without precision issues
<mareko>
this will allow it, but some pixels can be changed +-1 during the copy:
Nasina has quit [Read error: Connection reset by peer]
airlied has joined #dri-devel
gnuiyl has quit [Remote host closed the connection]
gnuiyl has joined #dri-devel
fantom_ has quit [Ping timeout: 480 seconds]
hazardou_shitman has joined #dri-devel
hazard_hitman has quit [Ping timeout: 480 seconds]
gnuiyl has quit [Quit: Leaving]
hazardou_shitman has quit []
hazardou_shitman has joined #dri-devel
gnuiyl has joined #dri-devel
hazardou_shitman has quit []
hazard_hitman has joined #dri-devel
The_Company has quit []
Company has joined #dri-devel
Kayden has quit [Quit: Leaving]
Kayden has joined #dri-devel
Nasina has joined #dri-devel
Nasina has quit [Read error: Connection reset by peer]
fab has joined #dri-devel
hazard_hitman has quit [Remote host closed the connection]
davispuh has quit [Ping timeout: 480 seconds]
Nasina has joined #dri-devel
Nasina has quit [Read error: Connection reset by peer]
Duke`` has joined #dri-devel
kzd has quit [Ping timeout: 480 seconds]
Nasina has joined #dri-devel
glennk has joined #dri-devel
sima has joined #dri-devel
dolphin has joined #dri-devel
jsa1 has joined #dri-devel
olivial has quit [Read error: Connection reset by peer]
olivial has joined #dri-devel
fab has quit [Quit: fab]
tzimmermann has joined #dri-devel
fab has joined #dri-devel
Duke`` has quit [Ping timeout: 480 seconds]
fab has quit [Quit: fab]
azerov has quit []
Nasina has quit [Read error: Connection reset by peer]
Nasina has joined #dri-devel
apinheiro has joined #dri-devel
vliaskov has joined #dri-devel
Nasina has quit [Read error: Connection reset by peer]
fab has joined #dri-devel
Nasina has joined #dri-devel
Nasina has quit [Read error: Connection reset by peer]
Nasina has joined #dri-devel
fantom has joined #dri-devel
sghuge has quit [Remote host closed the connection]
sghuge has joined #dri-devel
nchery has quit [Ping timeout: 480 seconds]
nchery has joined #dri-devel
cascardo_ has joined #dri-devel
calico has quit [Read error: Connection reset by peer]
calico has joined #dri-devel
calico is now known as Guest20823
warpme has joined #dri-devel
cascardo has quit [Ping timeout: 480 seconds]
lemonzest1 has joined #dri-devel
lemonzest has quit [Ping timeout: 480 seconds]
frieder has joined #dri-devel
kxkamil has joined #dri-devel
lynxeye has joined #dri-devel
olivial has quit [Read error: Connection reset by peer]
olivial has joined #dri-devel
smpl has joined #dri-devel
rasterman has joined #dri-devel
Karyon_ has joined #dri-devel
Karyon has quit [Ping timeout: 480 seconds]
kts has joined #dri-devel
<karolherbst>
mareko: interesting... I was seeing precision issues on iris as well with 565.. like returning 0.580392182 instead of 0.580645144 for red of 0x97c4. And I'm wondering if it's the same precision issues mentioning in the code?
<mareko>
karolherbst: it only happens on gfx6-8, I have a patch that enables the blit for gfx9+
<karolherbst>
I see
<karolherbst>
I am sometimes wondering if I need a more detailed check with is_format_supported so drivers can report a different set of formats for GL and CL to account for random precision issues like that
<mareko>
I think it can be mitigated in drivers by using format reinterpretation, e.g. copy as r32_uint
<karolherbst>
but for now I'll probably ignore 565 and only land 10102, because that seems to work already
<karolherbst>
(and 21010)
<karolherbst>
mareko: so the issue I'm seeing on iris comes directly from txl and images are formatless in CL, so not sure it can be solved in shaders without adding some runtime lowering code or something
<mareko>
resource_copy_region isn't formatless
<mareko>
in drivers
<karolherbst>
right, not saying that resource_copy_region can't be fixed, but running shaders could still cause problems
<mareko>
indeed
<mareko>
FS outputs round towards zero, while image stores probably round towards nearest, which could be the problem
<karolherbst>
intel doesn't seem to advertise "CL_UNORM_SHORT_565" in their CL stack either, but they don't advertise many formats to begin with
<karolherbst>
yeah... maybe
<karolherbst>
though the difference on iris was bigger than you'd see from rounding issues, unless there is some internal precision between what floats give you and 565/unorm
<pinchartl>
+ * All drivers should support XRGB8888, even if the hardware cannot support
<pinchartl>
+ * it.
<pinchartl>
+ * DRM drivers should not do software color conversion, and
<pinchartl>
+ * only advertise the formats they support in hardware.
<pinchartl>
that sounds a bit... contradictory ?
<mripard>
the controversy about that code seems to come from the exceptions part, not the XRGB8888 requirement
<mripard>
yeah, I guess it could be rephrased
<mripard>
up for the job?
<pinchartl>
no, because I don't know what the requirement is :-)
<mripard>
you didn't accept it as an excuse in the past :)
<pinchartl>
:-D
jbarnes has quit [Read error: Connection reset by peer]
<pinchartl>
I haven't followed the discussion at all, and I assume this ship has long sailed, but forcing XRGB8888 support for hardware that only supports ARGB8888 doesn't seem very nice. it should have been relatively easy for userspace that support XRGB8888 to also support ARGB8888
jbarnes has joined #dri-devel
<zamundaaa[m]>
[@_oftc_pinchartl:matrix.org](https://matrix.to/#/@_oftc_pinchartl:matrix.org): the problem is that legacy doesn't really have supported formats
<mripard>
yeah, the issue isn't with having support in the future
<mripard>
it's about what we inherit from the past :)
<pinchartl>
legacy as in native KMS without format support ?
<zamundaaa[m]>
And yet, compositors assume XRGB8888 to be supported with legacy modesetting. I'm sure some assume it with atomic too
<emersion>
yeah, XRGB8888 is assumed to be always supported
<emersion>
some drivers not supporting it natively perform CPU conversion
<pq>
This may be complicated that userspace will probably favor XRGB over ARGB if both are supported. That's kind of horrible for hardware that only supports ARGB.
<pq>
pinchartl, what kind of hardware supports ARGB but not XRGB?
alarumbe has joined #dri-devel
<glehmann>
Why do some NIR passes use nir_instr_free on removed instructions, but not all?
<zamundaaa[m]>
a driver only advertising ARGB8888 with the atomic API could potentially be fine, as it's expected for drm clients to check the list of supported formats
<pq>
pinchartl, does that hardware support not support "pixel blend mode" "none"?
<zamundaaa[m]>
But you still need to support it for legacy modesetting
dantob has joined #dri-devel
<zmike>
glehmann: I think instrs are part of the ralloc ctx, so it isn't necessary
<glehmann>
but then why would you still want to call it manually?
lemonzest has quit [Ping timeout: 480 seconds]
<zmike>
people don't know?
<pinchartl>
pq: the Xilinx dpsub driver
<pinchartl>
drivers/gpu/drm/xlnx/zynqmp_*
<pinchartl>
in particular zynqmp_kms.c for the KMS API
<pq>
pinchartl, I mean, what's the hardware like? What does it use the alpha channel for?
<pinchartl>
it has two planes and a blender
<pinchartl>
the zpos is fixed
<pq>
and no blend-mode control?
MoeIcenowy has joined #dri-devel
<pinchartl>
the bottom plane is called the video layer and the top plane the graphics layer
<pinchartl>
the blender has a global alpha control
<pinchartl>
but as far as I can tell it doesn't offer a way to ignore the alpha channel of the graphics layer
<pinchartl>
the hardware doesn't support plane positioning, which makes things a bit simpler
<pq>
I mean blend mode: none, premult, coverage? It's hard-wired to one of them?
<pinchartl>
from a KMS point of view, if the graphics layer is enabled with XRGB *and* the global alpha is set to opaque, then the video layer should not be visible anywhere, so the hardware could be programmed to disable the video layer
<pinchartl>
let me check the modes
<pq>
hmm, I hope that offers a solution.
<pq>
Legacy KMS with multiple planes is dragons anyway, so maybe that trick help get legacy KMS to support XRGB, and then planes users are atomic which should be able to deal with the absence of XRGB.
lemonzest has joined #dri-devel
phasta has joined #dri-devel
jfalempe has joined #dri-devel
<pinchartl>
pq: as far as I can tell the blending mode is not configurable
<pinchartl>
it's not even documented, the documentation doesn't indicate if it's premultiplied or not
<pq>
ok
<pq>
hah
dantob has quit []
<pinchartl>
I think it's not premultiplied
<emersion>
not premultiplied would be an issue, KMS is premult by default unless the compositor sets the optional prop explicitly
warpme has quit []
<pinchartl>
that's what the hardware does I'm afraid :-(
<pq>
whelp, it must be a new driver, so you cannot regress anything. :-)
<pq>
You could expose the "pixel blend mode" property with the only option that the hardware implements.
<pq>
That way userspace at least knows.
<vsyrjala>
someone could type up a patch to enforce that the driver expose that prop if it exposes any alpha formats. though that person would also have to fix up all the existing drivers
<pinchartl>
it's a good idea
dolphin has quit [Quit: Leaving]
warpme has joined #dri-devel
frankbinns has quit [Remote host closed the connection]
frankbinns has joined #dri-devel
Nasina has joined #dri-devel
kzd has joined #dri-devel
Nasina has quit [Ping timeout: 480 seconds]
frieder has quit [Remote host closed the connection]
YuGiOhJCJ has quit []
epoch101 has quit []
epoch101 has joined #dri-devel
davispuh has joined #dri-devel
Guest20823 has quit [Remote host closed the connection]
calico has joined #dri-devel
ed__ has joined #dri-devel
<MrCooper>
zamundaaa[m]: do you already have some kind of prototype or something for getting timing feedback from the atomic commit ioctl?
asrivats_ has joined #dri-devel
Duke`` has joined #dri-devel
ed__ has quit []
edt_ has joined #dri-devel
<edt_>
in mesa MRs they often quote fossil stats. How are they generated (eg what do you run etc.) Are there docs anywhere?
hazard_hitman has joined #dri-devel
phasta has quit [Quit: WeeChat 4.6.2]
hansg has joined #dri-devel
dsimic is now known as Guest20971
dsimic has joined #dri-devel
edt_ has quit [Remote host closed the connection]
Guest20971 has quit [Ping timeout: 480 seconds]
croissant_ has joined #dri-devel
bolson has joined #dri-devel
epoch101 has quit [Ping timeout: 480 seconds]
edt_ has joined #dri-devel
croissant has quit [Ping timeout: 480 seconds]
Company has quit [Quit: Leaving]
hazard_hitman has quit [Ping timeout: 480 seconds]
MrCooper has quit [Remote host closed the connection]
<robclark>
yeah, probably
<robclark>
thx for the heads up
MrCooper has joined #dri-devel
<zamundaaa[m]>
[@_oftc_MrCooper:matrix.org](https://matrix.to/#/@_oftc_MrCooper:matrix.org): I have an idea for the API I want, nothing more than that though
Caterpillar has quit [Quit: Konversation terminated!]
<zamundaaa[m]>
That API would really just be an additional timestamp in the pageflip callback
Caterpillar has joined #dri-devel
Caterpillar has quit []
hansg has quit [Ping timeout: 480 seconds]
jsa2 has joined #dri-devel
Caterpillar has joined #dri-devel
<MrCooper>
my thinking was similar, possibly multiple additional timestamps though
jsa1 has quit [Ping timeout: 480 seconds]
nchery has quit [Ping timeout: 480 seconds]
Caterpillar has quit [Quit: Konversation terminated!]
Caterpillar has joined #dri-devel
nchery has joined #dri-devel
ced117_ has joined #dri-devel
ced117 has quit [Ping timeout: 480 seconds]
Caterpillar has quit [Quit: Konversation terminated!]
Caterpillar has joined #dri-devel
<edt_>
how does one generate the fossil reports seen in many MRs? Docs anywhere?
Jeremy_Rand_Talos_ has quit [Remote host closed the connection]
<pendingchaos>
some people use private fossils, because they are from proprietary applications
Jeremy_Rand_Talos_ has joined #dri-devel
croissant_ has quit []
croissant has joined #dri-devel
Caterpillar has quit [Quit: Konversation terminated!]
Caterpillar has joined #dri-devel
hansg has joined #dri-devel
<edt_>
pendingchaos Thanks
Caterpillar has quit [Quit: Konversation terminated!]
Caterpillar has joined #dri-devel
Caterpillar has quit []
warpme is now known as Guest21032
<edt_>
now I just have to find the what supplies the commands/scripts on arch
<zamundaaa[m]>
[@_oftc_MrCooper:matrix.org](https://matrix.to/#/@_oftc_MrCooper:matrix.org): what additional timestamps are you thinking of?
calico has quit [Remote host closed the connection]
idr has joined #dri-devel
tobiasjakobi has joined #dri-devel
tobiasjakobi has quit [Remote host closed the connection]
Caterpillar has joined #dri-devel
Caterpillar has quit [Quit: Konversation terminated!]
Caterpillar has joined #dri-devel
Caterpillar has quit [Quit: Konversation terminated!]
Caterpillar has joined #dri-devel
coldfeet has joined #dri-devel
jsa2 has quit [Ping timeout: 480 seconds]
caitcatd- has joined #dri-devel
chiku has joined #dri-devel
Caterpillar has quit [Quit: Konversation terminated!]
Caterpillar has joined #dri-devel
caitcatdev has quit [Ping timeout: 480 seconds]
Sid127 has quit [Ping timeout: 480 seconds]
fab has quit [Quit: fab]
fab has joined #dri-devel
fab is now known as Guest21056
Caterpillar has quit [Quit: Konversation terminated!]
Caterpillar has joined #dri-devel
Guest21032 has quit []
Caterpillar has quit [Quit: Konversation terminated!]
Caterpillar has joined #dri-devel
jkrzyszt has quit [Quit: Konversation terminated!]
jsa1 has joined #dri-devel
Caterpillar has quit [Quit: Konversation terminated!]
Caterpillar has joined #dri-devel
Caterpillar has quit []
Caterpillar has joined #dri-devel
Guest21056 has quit []
fab_ has joined #dri-devel
fab_ is now known as Guest21076
Caterpillar has quit [Quit: Konversation terminated!]
Caterpillar has joined #dri-devel
Caterpillar has quit []
Caterpillar has joined #dri-devel
Guest21076 has quit []
Caterpillar has quit [Quit: Konversation terminated!]
Caterpillar has joined #dri-devel
kxkamil has quit []
rasterman has quit [Quit: Gettin' stinky!]
iive has joined #dri-devel
gouchi has joined #dri-devel
gouchi has quit [Remote host closed the connection]
kxkamil has joined #dri-devel
simon-perretta-img__ has quit []
simon-perretta-img has joined #dri-devel
hansg has quit [Quit: Leaving]
Caterpillar has quit [Quit: Konversation terminated!]
Caterpillar has joined #dri-devel
psykose has quit [Remote host closed the connection]
Caterpillar has quit [Quit: Konversation terminated!]
Caterpillar has joined #dri-devel
alanc has quit [Remote host closed the connection]
alanc has joined #dri-devel
coldfeet has quit [Quit: leaving]
coldfeet has joined #dri-devel
feaneron has quit [Ping timeout: 480 seconds]
olivial has quit [Read error: Connection reset by peer]
olivial has joined #dri-devel
<dcbaker>
eric_engestrom: BTW, I've looked into the opposite of a --force-fallback-for option, I have some ideas but none of them are straight forward unfortunately :/
simon-perretta-img_ has joined #dri-devel
simon-perretta-img has quit [Ping timeout: 480 seconds]
jsa1 has quit [Ping timeout: 480 seconds]
coldfeet has quit [Quit: Lost terminal]
simon-perretta-img_ has quit []
simon-perretta-img has joined #dri-devel
Caterpillar has quit [Quit: Konversation terminated!]
Caterpillar has joined #dri-devel
feaneron has joined #dri-devel
Caterpillar has quit [Quit: Konversation terminated!]
Caterpillar has joined #dri-devel
asrivats_ has quit [Ping timeout: 480 seconds]
lynxeye has quit [Quit: Leaving.]
Caterpillar has quit [Quit: Konversation terminated!]
Caterpillar has joined #dri-devel
mvlad has quit [Remote host closed the connection]
Nasina has joined #dri-devel
SquareWinter68 has quit [Ping timeout: 480 seconds]
sghuge has quit [Remote host closed the connection]
sghuge has joined #dri-devel
rasterman has joined #dri-devel
SquareWinter68 has joined #dri-devel
vsyrjala has quit [Ping timeout: 480 seconds]
rasterman has quit [Quit: Gettin' stinky!]
vsyrjala has joined #dri-devel
jsa1 has joined #dri-devel
Duke`` has quit [Ping timeout: 480 seconds]
lemonzest has quit [Ping timeout: 480 seconds]
Nasina has quit [Read error: Connection reset by peer]
Nasina has joined #dri-devel
Caterpillar has quit [Quit: Konversation terminated!]
Caterpillar has joined #dri-devel
Nasina has quit [Read error: Connection reset by peer]
Nasina has joined #dri-devel
puck_ has quit [Remote host closed the connection]
Nasina has quit [Read error: Connection reset by peer]
Caterpillar has quit [Quit: Konversation terminated!]
sima has quit [Ping timeout: 480 seconds]
epoch101 has joined #dri-devel
puck_ has joined #dri-devel
epoch101 has quit []
Nasina has joined #dri-devel
asrivats has quit [Ping timeout: 480 seconds]
Nasina has quit [Ping timeout: 480 seconds]
asrivats has joined #dri-devel
jsa1 has quit [Ping timeout: 480 seconds]
epoch101 has joined #dri-devel
nchery has quit [Ping timeout: 480 seconds]
nchery has joined #dri-devel
Nasina has joined #dri-devel
apinheiro has quit [Quit: Leaving]
vliaskov has quit [Ping timeout: 480 seconds]
Nasina has quit [Read error: Connection reset by peer]