<mripard>
the structure size goes from 8 bytes to 16 afaiu, so even the IOCTL definition changes
Nasina has quit [Read error: Connection reset by peer]
jfalempe has quit [Quit: jfalempe]
Company has joined #dri-devel
<kode54>
cool, and they don't even check the ioctl command size to see if it's missing the flags field as some sort of compatibility check for older software
<daniels>
it uses the drm ioctl definitions and the drm_ioctl handler, so a) the size is encoded into the ioctl definition, and b) the kernel checks the passed size vs. the size it currently knows about and zero-fills any missing members
<daniels>
so it's actually perfectly safe to extend ioctls like that, if 0 means the old behaviour
Nasina has joined #dri-devel
sguddati has quit [Ping timeout: 480 seconds]
vliaskov has quit [Remote host closed the connection]
JRepin has quit []
JRepin has joined #dri-devel
lsntvt has joined #dri-devel
<mripard>
daniels: oh, TIL, that's cool.
<mripard>
thanks :)
sguddati has joined #dri-devel
<daniels>
np!
sguddati has quit [Ping timeout: 480 seconds]
Nasina has quit [Read error: Connection reset by peer]
Nasina has joined #dri-devel
davispuh has joined #dri-devel
coldfeet has quit [Quit: Lost terminal]
mvlad has joined #dri-devel
Nasina has quit [Read error: Connection reset by peer]
Nasina has joined #dri-devel
Nasina has quit [Read error: Connection reset by peer]
Nasina has joined #dri-devel
Nasina has quit [Read error: Connection reset by peer]
nerdopolis has joined #dri-devel
<stsquad>
do the gfxstream guys hang around here at all?
mceier is now known as Guest18465
mceier has joined #dri-devel
chaos_pr1 has joined #dri-devel
chaos_pr1 has quit []
alarumbe has joined #dri-devel
chaos_princess has quit [Ping timeout: 480 seconds]
Guest18465 has quit [Ping timeout: 480 seconds]
chaos_princess has joined #dri-devel
epoch101 has joined #dri-devel
jfalempe has joined #dri-devel
epoch101 has quit []
epoch101 has joined #dri-devel
feaneron has joined #dri-devel
jfalempe has quit [Quit: jfalempe]
Nasina has joined #dri-devel
jfalempe has joined #dri-devel
jfalempe has quit [Quit: jfalempe]
JRepin has quit []
JRepin has joined #dri-devel
pcercuei has quit [Quit: bbl]
jfalempe has joined #dri-devel
kzd has joined #dri-devel
oneforall2 has joined #dri-devel
kts has joined #dri-devel
alyssa has joined #dri-devel
<alyssa>
anyone care to review a 1-line nir change with no affect on anyone but AGX please?
<alyssa>
good enough for me, assignign to marge, thanks mike :p
<zmike>
🤝
Guest18235 has quit [Remote host closed the connection]
calico_ has joined #dri-devel
idr has joined #dri-devel
Duke`` has joined #dri-devel
<mareko>
karolherbst: do you expect rusticl to be available via distros with the rest of Mesa anytime soon? should we expect that rusticl will be the default OpenCL implementation in distros?
<karolherbst>
good question. It's already the default on asahi Linux
<karolherbst>
but I think that's more due to the lack of alternatives
<mareko>
the reasons don't matter as much as whether it will be packaged by major distros
<karolherbst>
well it's already packaged
<karolherbst>
at least in fedora it is
<karolherbst>
and it works on radeonsi OOTB (as long as you set "RUSTICL_ENABLE=radeonsi")
<karolherbst>
though not sure it's installed by default...
<mareko>
what's missing for radeonsi to have it enabled without env var?
<karolherbst>
but from a "feature" perspective, maybe passing the CTS would be good?
<karolherbst>
there are some minor issues left which would be good to figure out before that
<mareko>
is #[cfg... not a comment?
<karolherbst>
it's like a C++ attribute
<karolherbst>
and "cfg" is like #ifdef
<karolherbst>
"gallium-rusticl-enable-drivers" gets translated to those values
<karolherbst>
so if -Dgallium-rusticl-enable-drivers=asahi, then "rusticl_enable_asahi" is set
<karolherbst>
and cfg(rusticl_enable_asahi) enables the code then
jsa1 has joined #dri-devel
<karolherbst>
so if somebody compiles with -Dgallium-rusticl-enable-drivers=radeonsi, then the array there will list "radeonsi" and so it's enabled by default
<mareko>
how would you compare Rust to C in terms of productivity given that you have a lot of experience with it now?
<karolherbst>
don't really have to debug random memory related issues while programming
<karolherbst>
but it's kinda hard to directly compare, it's more that the compiler warns earlier if you are doing something bad
<karolherbst>
especially in regards to data ownership and threading
<karolherbst>
like code with data races won't compile unless you really force it
<karolherbst>
so it's more like I can focus on the high-level problems and deal less with random nonsense
dsimic is now known as Guest18469
<jannau>
it's not installed by default in fedora (or asahi linux). kinda struggling with the question which package has enough of an opencl use case to pull rusticl in
dsimic has joined #dri-devel
<karolherbst>
jannau: davinci resolve 🙃 but that's not a package
<karolherbst>
darktable supports OpenCL tho
<karolherbst>
there are a few other more scientific tools who do
<llyyr>
i dont think any distro installs opencl by default
<llyyr>
it's packaged and available on tumbleweed for ages too
<karolherbst>
yeah.. but they aren't necessarily great afaik
<karolherbst>
but dunno
jsa1 has quit [Remote host closed the connection]
<karolherbst>
FluidX3D is a physic simulation thing using CL
<karolherbst>
there are a couple of use cases but it's all more in the "pro tool" domain
<karolherbst>
maybe it could be useful for local AI/ML use cases, like translation models... there was also like.. uhm.. digikam supports face detection/recognition via CL and AI models?
<karolherbst>
that one might be more "avarage user" kind of software
<karolherbst>
folding at home as well, but no idea who is even using it these days...
<karolherbst>
anyway
<karolherbst>
there are some tools here and there
<jannau>
from fedora POV it probably makes sense to add (reverse) weak dependencies to mesa-libOpenCL for some/all of potential users but the argument for that is weak as long as asahi is the only platform workingout of the box
<karolherbst>
yeah..
<karolherbst>
though I think rusticl is in good enough shape these days to think about general enablement
<karolherbst>
I just don't wnat to force a support burden to mesa driver developers if they aren't fine with it tho
<karolherbst>
jannau: the big issue wiht that in the past was, that for clover radeonsi _was_ enable by default and it was just broken for most users... and it was so broken it could just hang your system
<karolherbst>
so I can kinda understand why those deps don't exist these days
Nasina has quit [Ping timeout: 480 seconds]
<karolherbst>
anyway.. the main idea was that rusticl should always be safe to install and it's up to distros to decide what drivers to enable
<karolherbst>
or just pick "auto" and then we decide what we think is safe to enable by default
<jannau>
clover is disabled since a month or so in the 25.1 fedora packages
<karolherbst>
it got removed upstream
<karolherbst>
so yeah
<karolherbst>
I think I even commented on the PR removing the support
<jannau>
post 25.1
<karolherbst>
"clover gets removed" was just the main reason to disable it
<karolherbst>
should probably also focus more on getting CI testing working out...
jfalempe has quit [Ping timeout: 480 seconds]
moxie_ has joined #dri-devel
moxie_ has quit []
cheako has quit [Quit: Connection closed for inactivity]
djbw has joined #dri-devel
frankbinns1 has quit [Ping timeout: 480 seconds]
JRepin has quit []
JRepin has joined #dri-devel
<llyyr>
uhhhh the latest commit to mesa main has an unresolved merge conflict
<llyyr>
nvm
Jeremy_Rand_Talos has quit [Remote host closed the connection]
Jeremy_Rand_Talos has joined #dri-devel
funderscore is now known as f_
Nasina has joined #dri-devel
jfalempe has joined #dri-devel
anholt has joined #dri-devel
warpme has quit []
Nasina has quit [Ping timeout: 480 seconds]
epoch101 has quit [Ping timeout: 480 seconds]
jfalempe has quit [Quit: jfalempe]
frankbinns1 has joined #dri-devel
lsntvt has quit [Ping timeout: 480 seconds]
tzimmermann has quit [Quit: Leaving]
Nasina has joined #dri-devel
<alyssa>
jannau: I kinda want to ship opencl ootb on FAR at least because macOS does so
<alyssa>
but also I do not use any applications whatsoever with CL so there's that lol
sima has quit [Ping timeout: 480 seconds]
parthi has quit []
<karolherbst>
I should at some point check what apple advertises and see how hard it's to add the missing bits
aswar002_ has quit []
zzyiwei has joined #dri-devel
fab_ has joined #dri-devel
fab_ is now known as Guest18472
Guest18472 has quit []
kts has quit [Quit: Konversation terminated!]
djbw has quit [Ping timeout: 480 seconds]
epoch101 has joined #dri-devel
rasterman has quit [Quit: Gettin' stinky!]
JRepin has quit []
JRepin has joined #dri-devel
tyalie has joined #dri-devel
aswar002 has joined #dri-devel
sima has joined #dri-devel
iive has joined #dri-devel
lsntvt has joined #dri-devel
jsa1 has joined #dri-devel
JRepin has quit [Remote host closed the connection]
jsa1 has quit [Remote host closed the connection]
JRepin has joined #dri-devel
zzyiwei has quit [Quit: leaving]
yogesh_m1 has joined #dri-devel
yogesh_mohan has quit [Ping timeout: 480 seconds]
alanc has quit [Remote host closed the connection]
alanc has joined #dri-devel
feaneron has quit [Ping timeout: 480 seconds]
Namarrgon has quit [Quit: WeeChat 4.6.1]
Namarrgon has joined #dri-devel
Nasina has quit [Ping timeout: 480 seconds]
djbw has joined #dri-devel
rasterman has joined #dri-devel
YuGiOhJCJ has joined #dri-devel
olivial has quit [Read error: Connection reset by peer]
olivial has joined #dri-devel
Nasina has joined #dri-devel
mvlad has quit [Remote host closed the connection]
Nasina has quit [Remote host closed the connection]