03:02 <bamse> kathirav: wouldn't that affect the other targets of that yaml as well?

03:02 <bamse> kathirav: please send the necessary patch(es) to move us in the right direction...if that's a revert, than send that and provide an explanation

14:35 <kathirav> Thanks bamse, Again IIUC, we should start using mmio-sram going forward and not disturb anything which are already described in the yaml (https://lore.kernel.org/all/00f6d696-a8d2-41a5-819a-dc1ed87d35bb@kernel.org/). Since the driver changes which uses the IPQ5424's IMEM is not yet merged, so I would like to revert the binding change and use the

14:35 <kathirav> mmio-sram. Yeah, let me send out the patches in sometime.

16:12 <z3ntu> Looks like the resin (volume down) driver likes to wake up the device from suspend when pressing the button. For pwrkey obviously wanted but volume down not so much. Does this need to be adjusted in dts or driver? (Or user space?)

17:41 <sgerhold> z3ntu: The device_init_wakeup(&pdev->dev, **1**); in pm8941-pwrkey.c sets the default, it can be changed from userspace. It doesn't make much sense to have it enabled by default for resin, but changing it now might be tricky

17:41 <sgerhold> ideally the driver would look for "wakeup-source" in the DT ...

18:22 <z3ntu> sgerhold you think it's a good idea to send a patch for that and see what people say?

18:23 <z3ntu> Imo on at least 99% of phones this is not expected behavior

18:23 <z3ntu> For devboards, maybe? On laptops (do they wire up resin?) probably also not?

18:24 <z3ntu> But then maaaaybe pwrkey should have the same behavior but there it's definitely breaking to not have this by default

18:25 <z3ntu> Like reverse questions, is it a use case for some boards to disable wakeup-source on pwrkey?

18:55 <bamse> z3ntu: yes, sending a patch and making a case for resin to be default non-wake makes sense...it would "break" existing users...but that's just something we'd have to take into consideration

18:56 <bamse> z3ntu: at least if we have a patch we can argue somewhere and we have documentation of the outcome

18:56 <bamse> the crd is using resin for a volume down button...but i don't think that was inherited in any of the designs

19:00 <z3ntu> Afaik most phones are using resin for vol-down, so that's from mtp/idp I guess

19:00 <z3ntu> bamse but ok, I'll try and make a patch tomorrow

19:18 <bamse> z3ntu: right, and i'd argue that if there actually are real users of such devices...they would agree with your view on this

19:18 <bamse> z3ntu: i'm not sure what use cases there are for disabling wakeup on power key though...

19:33 <z3ntu> Yes, for pwrkey that was my point as well, but since it's the same driver and I'll only have this behavior for resin, it's important to distinguish

23:18 <konradybcio> i use resin wakeup as a feature.. needs no edits to systemd configs to prevent it from also shutting down the system unlike the power button

23:19 <konradybcio> but i suppose i can accept the added required 1 LoDTS on my end