ChanServ changed the topic of #dri-devel to: <ajax> nothing involved with X should ever be unable to find a bar
flto has quit [Remote host closed the connection]
iive has quit [Quit: They came for me...]
nerdopolis_ has joined #dri-devel
nerdopolis is now known as Guest21888
nerdopolis_ is now known as nerdopolis
Guest21888 has quit [Read error: Connection reset by peer]
oneforall2 has quit [Ping timeout: 480 seconds]
The_Company has joined #dri-devel
Company has quit [Ping timeout: 480 seconds]
The_Company has quit []
Fya has joined #dri-devel
Calandracas has joined #dri-devel
<Fya> If I may be some bold to make a joke; https://files.catbox.moe/esvuyu.png But in all seriousness, is there something wrong with ANV's acceleration structures?
<Fya> s/some bold/bold enough
Calandracas_ has quit [Ping timeout: 480 seconds]
<HdkR> That's some good stuff right there.
oneforall2 has joined #dri-devel
TMM has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
TMM has joined #dri-devel
oneforall2 has quit [Remote host closed the connection]
glennk has joined #dri-devel
kasper93 has joined #dri-devel
kasper93 has quit []
kasper93 has joined #dri-devel
Jeremy_Rand_Talos__ has quit [Remote host closed the connection]
Jeremy_Rand_Talos__ has joined #dri-devel
oneforall2 has joined #dri-devel
zsoltiv__ has quit [Read error: Connection reset by peer]
zsoltiv_ has joined #dri-devel
nerdopolis has quit [Ping timeout: 480 seconds]
flto has joined #dri-devel
sima has joined #dri-devel
kzd has quit [Ping timeout: 480 seconds]
davispuh has quit [Ping timeout: 480 seconds]
moxie has quit [Quit: WeeChat 4.6.3]
moxie has joined #dri-devel
zsoltiv___ has joined #dri-devel
zsoltiv_ has quit [Ping timeout: 480 seconds]
shoragan has quit [Ping timeout: 480 seconds]
chewitt has joined #dri-devel
parthiban has joined #dri-devel
zsoltiv___ has quit [Read error: Connection reset by peer]
zsoltiv__ has joined #dri-devel
Duke`` has joined #dri-devel
kts has joined #dri-devel
moxie has quit [Quit: WeeChat 4.6.3]
moxie has joined #dri-devel
frieder has joined #dri-devel
tzimmermann has joined #dri-devel
kts has quit [Quit: Konversation terminated!]
sghuge has quit [Remote host closed the connection]
sghuge has joined #dri-devel
cascardo_ has joined #dri-devel
cascardo has quit [Ping timeout: 480 seconds]
frieder has quit [Ping timeout: 480 seconds]
MrCooper has joined #dri-devel
frieder has joined #dri-devel
kts has joined #dri-devel
shoragan has joined #dri-devel
apinheiro has joined #dri-devel
lynxeye has joined #dri-devel
jkrzyszt has joined #dri-devel
coldfeet has joined #dri-devel
rasterman has joined #dri-devel
YuGiOhJCJ has joined #dri-devel
siak has joined #dri-devel
siak has quit [Remote host closed the connection]
siak has joined #dri-devel
kts has quit [Ping timeout: 480 seconds]
mmeto has quit [Ping timeout: 480 seconds]
siak_ has joined #dri-devel
siak has quit [Ping timeout: 480 seconds]
vimproved has quit [Ping timeout: 480 seconds]
siak has joined #dri-devel
vimproved has joined #dri-devel
siak_ has quit [Ping timeout: 480 seconds]
siak_ has joined #dri-devel
<Ermine> are there libdrm env variables for debug output?
<tzimmermann> sima, thanks again for dealing with that regression on Fri. what's the current status? AFAICS the reverts didn't make it, but the original fix went into upstream
siak has quit [Ping timeout: 480 seconds]
Jeremy_Rand_Talos_ has joined #dri-devel
vliaskov has joined #dri-devel
Jeremy_Rand_Talos__ has quit [Ping timeout: 480 seconds]
<pq> Ermine, 'git grep -p getenv' says LIBGL_DEBUG=verbose might do something.
coldfeet has quit [Ping timeout: 480 seconds]
siak has joined #dri-devel
coldfeet has joined #dri-devel
siak_ has quit [Ping timeout: 480 seconds]
siak_ has joined #dri-devel
<karolherbst> Anybody want to review my basic Initializer support for CrossWorkgroup Variables MR? https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24515/diffs
siak has quit [Ping timeout: 480 seconds]
coldfeet has quit [Ping timeout: 480 seconds]
phasta has joined #dri-devel
rsalvaterra has quit []
rsalvaterra has joined #dri-devel
sguddati has joined #dri-devel
YuGiOhJCJ has quit []
siak has joined #dri-devel
sguddati has quit [Ping timeout: 480 seconds]
siak_ has quit [Ping timeout: 480 seconds]
<sima> tzimmermann, yeah see my reply to linus' mails on dri-devel, I figured not rushing the reverts is the prudent choice
<sima> plus turned out it was an epoll regression which was responsible for the delays
siak_ has joined #dri-devel
<sima> tzimmermann, I do think switching back to ->import_attach.dmabuf is prudent, I'll type up a mail with justification for that
<tzimmermann> sima, but the patches are still supposed to be reverted?
<sima> and also what I think the options for the handle_count patches are
<pinchartl> sima: it was nice reading Linus apologizing. that feels good
<tzimmermann> ah, i see
<tzimmermann> :D
<sima> tzimmermann, yeah since it was pretty clear that your fix was good enough for now for linus and his regressions something else, I didn't want to rush anything
<sima> given our track record at not understanding this part of the code base
<tzimmermann> makes sense
<sima> gives us another week at scratching our heads :-)
<tzimmermann> i think we should already revert the patches outside of drm-misc (amd + tegra IIRC). otherwise things will get chaotic in he next release cycle
siak has quit [Ping timeout: 480 seconds]
<tzimmermann> with the most recent fix in place, we can also undo the import_attach->dmabuf changes without touching the framebuffer-handle changes
<tzimmermann> so that problem with handles would remain fixed for now (until we have a better solution there)
<sima> yeah that's what I'm leaning towards, too
<sima> at least for v6.16
siak has joined #dri-devel
siak_ has quit [Ping timeout: 480 seconds]
siak_ has joined #dri-devel
siak has quit [Ping timeout: 480 seconds]
<Ermine> pq: didn't help, but thank you nonetheless
<Ermine> is ARM_AFBC a modifier?
<Ermine> drm_info groups plane's IN_FORMATS, and several groups are labelled by "ARM_AFBC(...)"
caitcatdev has quit []
Sid127 has quit [Quit: ZNC - https://znc.in]
Sid127 has joined #dri-devel
caitcatdev has joined #dri-devel
siak has joined #dri-devel
siak_ has quit [Remote host closed the connection]
plarpoon has joined #dri-devel
plarpoon has quit []
siak_ has joined #dri-devel
siak has quit [Ping timeout: 480 seconds]
Guest21871 has quit []
siak_ has quit []
caitcatdev has quit []
Sid127 has quit [Quit: ZNC - https://znc.in]
siak has joined #dri-devel
Sid127 has joined #dri-devel
feaneron has joined #dri-devel
caitcatdev has joined #dri-devel
warpme has joined #dri-devel
sguddati has joined #dri-devel
caitcatdev has quit []
Sid127 has quit [Quit: ZNC - https://znc.in]
siak_ has joined #dri-devel
Sid127 has joined #dri-devel
sguddati has quit [Ping timeout: 480 seconds]
caitcatdev has joined #dri-devel
siak has quit [Ping timeout: 480 seconds]
guludo has joined #dri-devel
sguddati has joined #dri-devel
siak has joined #dri-devel
<sima> tzimmermann, typed some text with my thoughts
<tzimmermann> thanks
<sima> maybe one thing to add that I forgot: I wouldn't rush the handle_count reverts into 6.16, even if you decide to go with them
<sima> this is all a bit too scary stuff
siak_ has quit [Ping timeout: 480 seconds]
<pq> Ermine, AFBC is a set of modifiers, yes.
sguddati has quit [Ping timeout: 480 seconds]
warpme has quit []
nerdopolis has joined #dri-devel
kzd has joined #dri-devel
siak_ has joined #dri-devel
feaneron has quit [Ping timeout: 480 seconds]
siak has quit [Ping timeout: 480 seconds]
cascardo_ is now known as cascardo
warpme has joined #dri-devel
davispuh has joined #dri-devel
guludo has quit [Ping timeout: 480 seconds]
guludo has joined #dri-devel
kasper93_ has joined #dri-devel
kasper93 is now known as Guest21924
kasper93_ is now known as kasper93
kts has joined #dri-devel
kasper93 has quit [Read error: Connection reset by peer]
Guest21924 has quit [Ping timeout: 480 seconds]
kasper93 has joined #dri-devel
kasper93_ has joined #dri-devel
kasper93 is now known as Guest21926
kasper93_ is now known as kasper93
Guest21926 has quit [Ping timeout: 480 seconds]
warpme has quit []
edolnx_ has quit []
edolnx has joined #dri-devel
frieder has quit [Remote host closed the connection]
frieder has joined #dri-devel
dsimic is now known as Guest21928
dsimic has joined #dri-devel
phasta has quit [Quit: WeeChat 4.6.2]
frieder has quit [Remote host closed the connection]
Guest21928 has quit [Ping timeout: 480 seconds]
<robclark> karolherbst: is this even legal (ie. local size 0x0x64):
<robclark> (rusticl doesn't seem to throw an error.. but the grid seems to get dropped)
Company has joined #dri-devel
<karolherbst> well.. I don't think it's illegal, but I think it's legal that it runs 0 threads
<karolherbst> "The total number of work-items in a work-group is computed as local_work_size[0] × …​ × local_work_size[work_dim - 1]"
<karolherbst> well..
<karolherbst> maybe undefined if you go by this: "Otherwise, when non-uniform work-groups are not supported, the size of each work-group must be uniform. If local_work_size is specified, the values specified in global_work_size[0], …​, global_work_size[work_dim - 1] must be evenly divisible by the corresponding values specified in local_work_size[0], …​,
<karolherbst> local_work_size[work_dim - 1]. If local_work_size is NULL, the OpenCL runtime must choose a uniform work-group size."
<karolherbst> that _should_ run in a division by 0 thing...
<robclark> ok.. so UB
<karolherbst> rusticl seems to try to make it work regardless
<karolherbst> but... I'm sure it might ask for nonsense values
<karolherbst> let me see what intel would be doing...
<karolherbst> it runs..
<karolherbst> ehh wait
<karolherbst> I messed up
<karolherbst> intel fails to launch :)
<karolherbst> mhh
<karolherbst> rusticl seems to throw an error for me...
<karolherbst> robclark: is it 0x0x64 or 64x0x0?
<karolherbst> and what's the dimension?
<robclark> no, it really is 0x0x64
<karolherbst> like if work_dim == 1 then this is perfectly legal
<karolherbst> probably
<karolherbst> depending if [0] or [2] being 64
<robclark> somehow clintercept isn't printing workdim
<karolherbst> rusticl does pipe work_dim through to the driver
<karolherbst> so it should show up in pipe_grid_info
<robclark> correct.. just not logged here
<karolherbst> so maybe your driver just sees 0 and launches 0 threads
<robclark> anyways, I can debug more, I just wanted to see what the correct/expected behavior is
<karolherbst> and should sanitize the values to 1? could also make it the frontends responsibility
<karolherbst> could also hard code 3 and make it's the frontends problem
<robclark> from looking at cmdstream trace, I think the grid gets dropped
<karolherbst> yeah.. but can you configure a 1 dimensional grid?
<karolherbst> or do you assume it's always 3D
<robclark> yup, we pass workdim down to the hw
<karolherbst> ahh..
<robclark> (gl and zink always assume 3d due to api limitations)
<karolherbst> does it work forcing 3D and replacing 0s with 1s?
<karolherbst> probably I guess..
<robclark> I don't _think_ it is getting as far as gallium but maybe I'm lining up the CP_EXEC_CS in cmdstream incorrectly
<karolherbst> mhh
<karolherbst> well launching a 8, 0, 0 with dim 1 seems to work on iris
<karolherbst> GALLIUM_TRACE=/dev/stdout
<karolherbst> I think I've fixed it enough that it shouldn't crash anymore
<karolherbst> impossible to read but: <arg name='info'><struct name='pipe_grid_info'><member name='variable_shared_mem'><uint>0</uint></member><member name='block'><array><elem><uint>8</uint></elem><elem><uint>1</uint></elem><elem><uint>1</uint></elem></array></member><member
<karolherbst> name='grid'><array><elem><uint>16</uint></elem><elem><uint>1</uint></elem><elem><uint>1</uint></elem></array></member><member name='indirect'><null/></member><member name='indirect_offset'><uint>0</uint></member><member
<karolherbst> name='globals'><array><elem><ptr>0x02b13750</ptr></elem><elem><ptr>0x02b13cb0</ptr></elem><elem><ptr>0x02b0b390</ptr></elem><elem><ptr>0x02b13990</ptr></elem></array></member></struct></arg>
sguddati has joined #dri-devel
<karolherbst> maybe rusticl should sanitize those 0s with 1s, maybe we should just stop pretending it's a thing on hardware 🙃
<karolherbst> like dunno
<robclark> I mean, this could be an app bug.. not sure why on a x1-85 I get sane(ish) looking 1x1x64 but on this smaller thing I get 0x0x64 ;-)
<karolherbst> mhhh
<karolherbst> I see
<karolherbst> maybe some math going wrong
<karolherbst> I've hit CTS bugs where the math was broken and it sent nonsense values because it couldn't cope with limits being too high/low
<karolherbst> but maybe rusticl should also error when it hits a 0, just not sure it's _explicitly_ stated that it's an error
<robclark> so I see in the driver the launch_grid before and after the "bogus" one, but the "bogus" on is skipped.. adding some assert!()
<karolherbst> mhhh
* robclark wonders why rust assert!() generates 96 levels of assert related stack frames :-P
<karolherbst> :D
<karolherbst> it uhm.. shouldn't, but sometimes...
<robclark> fwiw:
<robclark> work_dim=3
<karolherbst> fun
<karolherbst> anyway, brb
<karolherbst> well might take a while actually
<robclark> np, I can debug more.. I was just wanted to get your spec opinion on what should happen ;-)
<robclark> yup, we are hitting that case.. so at least that mystery is solved
epoch101 has joined #dri-devel
kts has quit [Quit: Konversation terminated!]
sguddati has quit [Ping timeout: 480 seconds]
bolson has joined #dri-devel
tzimmermann has quit [Quit: Leaving]
kts has joined #dri-devel
epoch101 has quit []
plarpoon has joined #dri-devel
<xeyler> does anyone happen to know if Neil Armstrong has been on vacation? i sent out a patch which will likely make its way upstream through him
<gfxstrand> mareko, ajax: Does one of you know what's up with setBackgroundContext? It's looking like maybe it's only releveant for DRI2 and since we burned that, maybe we can burn this, too?
epoch101 has joined #dri-devel
<MrCooper> gfxstrand: doubtful, since it's used in src/glx/dri3_glx.c
epoch101 has quit []
<alyssa> xeyler: last I heard he was somewhere in space
<vsyrjala> agd5f: hwentlan_: can i get some acks for merging the amd parts of https://patchwork.freedesktop.org/series/147541/ via drm-misc?
<karolherbst> robclark: ohh.. I couldn't find that part :) thanks for finding it
<karolherbst> robclark: though I think that's only valid for the _global_ size
<robclark> oh, well global size also had zero's
kts has quit [Quit: Konversation terminated!]
<karolherbst> hah
<robclark> 32/64 => 0
<karolherbst> ahh.. yeah...
<karolherbst> classic
<karolherbst> but I like that rusticl is at the state that most issues are actually application side bugs 🙃
<robclark> running tflite on a _tiny_ gpu exposes a lot of bad assumptions ;-)
<karolherbst> heh
<robclark> I guess no one ever tried running tensorflow on a watch before :-P
kts has joined #dri-devel
<karolherbst> :D
<xeyler> alyssa: got it. thanks.
lynxeye has quit [Quit: Leaving.]
hikiko has joined #dri-devel
Mangix has quit [Read error: Connection reset by peer]
Mangix has joined #dri-devel
<alyssa> xeyler: (I'm just being silly)
<gfxstrand> MrCooper: I see that. But I can't figure out what it actually does.
gabertron has quit [Remote host closed the connection]
gabertron has joined #dri-devel
jkrzyszt has quit [Quit: Konversation terminated!]
epoch101 has joined #dri-devel
epoch101 has quit []
cr0n has quit []
coldfeet has joined #dri-devel
rasterman has quit [Read error: Connection reset by peer]
rasterman has joined #dri-devel
siak_ has quit []
gabertron has quit [Remote host closed the connection]
gabertron has joined #dri-devel
coldfeet has quit [Ping timeout: 480 seconds]
plarpoon has quit []
feaneron has joined #dri-devel
sima has quit [Ping timeout: 480 seconds]
gabertron has quit [Remote host closed the connection]
xroumegue has joined #dri-devel
chewitt has quit [Quit: Zzz..]
gabertron has joined #dri-devel
gabertron has quit [Remote host closed the connection]
kts has quit [Quit: Konversation terminated!]
gabertron has joined #dri-devel
gabertron has quit [Remote host closed the connection]
epoch101 has joined #dri-devel
cr0n has joined #dri-devel
iive has joined #dri-devel
Fya has quit []
<xeyler> alyssa: oh.
<xeyler> well if that means he’s _not_ somewhere in space, does that mean the kernel needs a new maintainer for drm/panels? i wonder who i should forward this patch to..
feaneron has quit [Ping timeout: 480 seconds]
feaneron has joined #dri-devel
epoch101_ has joined #dri-devel
epoch101 has quit [Read error: Connection reset by peer]
coldfeet has joined #dri-devel
gabertron has joined #dri-devel
rasterman has quit [Remote host closed the connection]
gabertron has quit [Remote host closed the connection]
epoch101 has joined #dri-devel
epoch101_ has quit [Read error: Connection reset by peer]
rasterman has joined #dri-devel
feaneron has quit [Ping timeout: 480 seconds]
feaneron has joined #dri-devel
vliaskov has quit [Ping timeout: 480 seconds]
epoch101_ has joined #dri-devel
epoch101 has quit [Ping timeout: 480 seconds]
<mareko> tarceri: FYI, I'm going to merge this soon: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36091
rasterman has quit [Quit: Gettin' stinky!]
<mareko> gfxstrand: good question, it sets ctx as the current context in the consumer thread of glthread
<gfxstrand> Yes but what does that actually do?
<gfxstrand> Does the threaded context stuff call back into EGL/GLX?
<gfxstrand> I guess maybe for things like binding drawables to textures?
<gfxstrand> I guess I could delete it and see what explodes
<mareko> that's also a good approach
<mareko> it allso st/mesa and st/dri to call glX/EGL in the consumer thread, though I hope that never happens
<mareko> *allows
<gfxstrand> Yeah, that's what I was thinking
<gfxstrand> I could kind of see it for DRI2 but not DRI3
<gfxstrand> And it's only ever used for X11 and not Wayland so I'm having trouble coming up with use cases
<mareko> if st/dri calls back into GLX/EGL via callbacks, those callbacks could have beeen implemented by getting the current context from TLS instead of from parameters
coldfeet has quit [Remote host closed the connection]
<zmike> I deleted a lot of those callbacks
alanc has quit [Remote host closed the connection]
epoch101_ has quit [Ping timeout: 480 seconds]
alanc has joined #dri-devel
<mareko> fun idea: glX implemented on top of libEGL
<Sachiel> strange concept of fun
<mareko> it could be more fun than zink on lavapipe on softpipe
Calandracas_ has joined #dri-devel
Calandracas__ has joined #dri-devel
Calandracas has quit [Ping timeout: 480 seconds]
gabertron has joined #dri-devel
Calandracas_ has quit [Ping timeout: 480 seconds]
<alyssa> mareko: can we get a virtual machine boundary in there somewhere to make it extra fun? :P
<karolherbst> mareko: "self.screen().nir_options[shader as usize]"
TMM has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
TMM has joined #dri-devel
<karolherbst> just need to explicitly cast
Calandracas__ has quit [Ping timeout: 480 seconds]
<mareko> glX -> EGL -> zink -> venus -> glX -> EGL -> zink -> lavapipe -> softpipe
<mareko> zmike: ^^ your next new CI job
<karolherbst> if you run that on xwayland, do you get an EGL -> glX in front?
<mareko> that's just X I think
<karolherbst> mhhh could be
<karolherbst> so it's wayland -> glX
<karolherbst> no idea honestly
<karolherbst> mareko: ohh and also drop the unsafe around that, it's not needed anymore after your change
epoch101 has joined #dri-devel
<zmike> mareko: surely d3d12 in there somehow with dozen
<alyssa> take 1 down, pass it around, 98 layers of graphics on the stack
Calandracas has joined #dri-devel
<gfxstrand> Every day you can delete something from dri_interface.h is a good day. :D
<alyssa> =D
<gfxstrand> I'm going to run ALL OF CI on this, though. :joy:
<gfxstrand> Ugh... This might not work...
<gfxstrand> I might need to do actual work.
<gfxstrand> Actually, it might be okay. None of this should come from the thread
<gfxstrand> Okay, I'm gonna walk home while that CIs
Duke`` has quit [Ping timeout: 480 seconds]
dviola has quit [Ping timeout: 480 seconds]
zzyiwei has joined #dri-devel
sarnex has quit [Read error: Connection reset by peer]
leo60228 has quit [Read error: Connection reset by peer]
leo60228 has joined #dri-devel
sarnex has joined #dri-devel
tursulin_ has joined #dri-devel
tursulin has quit [Ping timeout: 480 seconds]
leo60228 has quit [Read error: Connection reset by peer]
leo60228 has joined #dri-devel
<karolherbst> eric_engestrom: you want to branch mesa tomorrow?
cyrinux949075 has joined #dri-devel
cyrinux94907 has quit [Ping timeout: 480 seconds]
zzyiwei has quit [Quit: leaving]
apinheiro has quit [Quit: Leaving]
northernking1 has joined #dri-devel
krumelmonster has quit [Ping timeout: 480 seconds]
northernking1 has quit [Remote host closed the connection]
dominoeffect has joined #dri-devel