<jani>
jfalempe: tzimmermann: saw the #if defined discussion from yesterday. maybe consider using IS_ENABLED() to simplify. #if IS_ENABLED(CONFIG_OF) && (IS_ENABLED(CONFIG_COMMON_CLK) || IS_ENABLED(CONFIG_REGULARTOR))
<jani>
I'd go so far as to say checks for CONFIG_ macros should *always* use IS_ENABLED() instead of #ifdef or #if defined
glennk has quit [Remote host closed the connection]
Company has joined #dri-devel
phasta has joined #dri-devel
warpme has joined #dri-devel
fab has joined #dri-devel
Nasina has quit [Remote host closed the connection]
phasta_ has joined #dri-devel
phasta has quit [Ping timeout: 480 seconds]
Nasina has joined #dri-devel
kts has joined #dri-devel
coldfeet has joined #dri-devel
<kj2>
I was working on a Crucible benchmark but started hitting linking errors like `crtstuff.c:(.text+0x76): relocation truncated to fit: R_X86_64_PC32 against `.bss'` where I think it's starting to hit the limit of the distance between some sections
<kj2>
All tests and benchmarks seems to be linked together into the single executable so I was thinking of maybe separating things. Thought I'd ask here before trying to do that in case people have objections
fab has quit [Ping timeout: 480 seconds]
hansg has quit [Quit: Leaving]
yrlf has quit [Quit: Ping timeout (120 seconds)]
yrlf has joined #dri-devel
jsa1 has quit [Ping timeout: 480 seconds]
<javierm>
tzimmermann: I just reviewed the Sitronix ST7571 driver. Please chime in if I said anything that's wrong there
Nasina has quit [Remote host closed the connection]
Nasina has joined #dri-devel
<tzimmermann>
didn'i ack it already :/
warpme has quit []
<tzimmermann>
javierm ^
<javierm>
tzimmermann: yes, you did and that's why I'm pointing it out
<tzimmermann>
i cannot say much about the bindings, but the other pathces have my r-b
<javierm>
tzimmermann: it's OK if you want to merge it as as. But IMO it needs some changes
<javierm>
*as is
<tzimmermann>
javierm, thanks for the additional reivew. those are quite a number of good points
<javierm>
tzimmermann: you are welcome
<javierm>
tzimmermann: the only comment that I was not 100% sure was the last one about the lifecycle
<javierm>
but IIRC from our previous conversations and posted fixes, we need both a .remove and .shutdown handlers
coldfeet has quit [Quit: Lost terminal]
<javierm>
to do drm_dev_unplug() + drm_atomic_helper_shutdown() and drm_atomic_helper_shutdown() respectively
warpme has joined #dri-devel
<tzimmermann>
javierm, thanks for the efidrm module review BTW
<javierm>
tzimmermann: yw
Nasina has quit [Read error: Connection reset by peer]
<tzimmermann>
the recent change to ssh.gitlab has destroyed my setup
<tzimmermann>
so i ran 'dim setup' to start anew
<tzimmermann>
doing 'dim rebuild-tip' returns 'Branch setup for the integration repo is borked'
<tzimmermann>
any ideas?
Nasina has joined #dri-devel
Nasina has quit [Read error: Connection reset by peer]
nerdopolis has joined #dri-devel
Nasina has joined #dri-devel
glennk has joined #dri-devel
kts has quit [Ping timeout: 480 seconds]
feaneron has joined #dri-devel
Nasina has quit [Read error: Connection reset by peer]
Nasina has joined #dri-devel
Nasina has quit [Read error: Connection reset by peer]
itoral has quit [Remote host closed the connection]
Nasina has joined #dri-devel
Nasina has quit [Read error: Connection reset by peer]
warpme has quit []
guludo has joined #dri-devel
warpme has joined #dri-devel
phasta_ has quit []
fab has joined #dri-devel
<jani>
auch
<jani>
the problem with 'dim setup' is that people run it maybe once per several years. there's no incentive to polish it
<jani>
tzimmermann: nightly.conf needs an update to ssh URLs, and I guess it also needs a mechanism to migrate
<jani>
sadly, no. but I also don't understand why it isn't working :(
davispuh has joined #dri-devel
<jani>
Hostname ssh.gitlab.freedesktop.org
<jani>
Host gitlab.freedesktop.org
<jani>
that's what I added to my .ssh/config and moved on, but obviously dim setup should do better
fab has quit [Quit: fab]
<tzimmermann>
jani, thanks for the help. i'll see what i can do
warpme has quit []
<jani>
tzimmermann: I wonder why we use the plain git@gitlab.freedesktop.org:drm/tip.git style at all. IIUC that could be ssh://git@gitlab.freedesktop.org/drm/tip.git with the protocol clearly stated
<jani>
I've also been getting sporadic permission denied errors from gitlab recently
<demarchi>
tzimmermann: that was fixed last week
<demarchi>
tzimmermann: do you have latest maintainer-tools checkout?
<demarchi>
tzimmermann: oops, it helps if I actually merge the MR
Daanct12 has quit [Read error: Connection reset by peer]
<jani>
demarchi: that basically drops all git@ssh.gitlab.freedesktop.org:drm/tip.git style urls, but I guess they should still work, and if the user has them configured, I think it's going to break
<demarchi>
it still has the ssh://git@ style as the first one
<jani>
by providing a lot of flexibility we've created a monster
Nasina has quit [Ping timeout: 480 seconds]
<jani>
demarchi: but does dim take that into account when trying to find the remote name based on the URL?
<demarchi>
jani: I always thought "why are we not using google's repo" to sync the repos
<demarchi>
jani: yes, it's in the old_urls
<demarchi>
if the remote is configured with anything that matches an entry in the old_urls array, it will suggest to change to the first from the current array
<jani>
demarchi: d'oh, too many levels of abstraction with this diff on top of diff :)
<jani>
demarchi: want to send a patch? I don't think we do MR's for drm-rerere
<demarchi>
the only breakage I can imagine is if people have git's insteadOf entries in their conf and match explicitly on git@, without ssh://
<demarchi>
jani: but we could leave the git@ without protocol too if you think it's risky
<jani>
nah, break it and require people to put in the protocl ;)
dolphin has quit [Quit: Leaving]
rsalvaterra has quit []
epoch101 has joined #dri-devel
<jani>
*if* it even breaks
<demarchi>
it's not very common to see people using insteadOf
rsalvaterra has joined #dri-devel
<demarchi>
I actually used sometimes to redirect git:// to https://, because of silly company proxies
<demarchi>
jani: do I add your s-o-b too?
<jani>
demarchi: I don't care
Nasina has joined #dri-devel
<jani>
not exactly copyright worthy either
Nasina has quit [Read error: Connection reset by peer]
Daanct12 has joined #dri-devel
<demarchi>
jani: alright, done
Nasina has joined #dri-devel
Nasina has quit [Read error: Connection reset by peer]
<jani>
demarchi: thanks! I also had a lightbulb moment and figured out what my issue was
<jani>
I had the IdentityFile set for gitlab.freedesktop.org but not for ssh.gitlab.freedesktop.org, so it ended up using the wrong key
kzd has joined #dri-devel
Nasina has joined #dri-devel
Nasina has quit [Read error: Connection reset by peer]
<demarchi>
jani: yeah... i use *.gitlab.freedesktop.org
<demarchi>
in my .ssh/config to set the username and identityfile
<javierm>
tzimmermann: as mentioned before, I may be wrong with the .remove and .shutdown i2c driver callbacks
<javierm>
if that's the case, I should fix my drivers because I've both currently and calling the aformentioned drm helpers
<javierm>
tzimmermann: it would be great if you can comment on the thread since you are quite familiar with these objects lifecycles
bolson has joined #dri-devel
Daanct12 has quit [Quit: WeeChat 4.6.0]
Nasina has joined #dri-devel
kts has quit [Ping timeout: 480 seconds]
Nasina has quit [Read error: Connection reset by peer]
jsa1 has joined #dri-devel
krushia has joined #dri-devel
<tzimmermann>
javierm, i think it only needs the unplug call
<tzimmermann>
after that, the shutdown doesn't do anything
<tzimmermann>
technically it's then disabled, but that appears pointless
<tzimmermann>
for shutdown, it might do shutdown, i think
sima has joined #dri-devel
hansg has joined #dri-devel
shalem has joined #dri-devel
shalem has quit [Remote host closed the connection]
jsa1 has quit [Ping timeout: 480 seconds]
yuq825 has quit [Remote host closed the connection]
frieder has quit [Remote host closed the connection]
yuq825 has joined #dri-devel
sguddati has joined #dri-devel
Duke`` has joined #dri-devel
aravind has quit [Ping timeout: 480 seconds]
warpme has quit []
sguddati has quit [Ping timeout: 480 seconds]
jsa1 has joined #dri-devel
epoch101_ has joined #dri-devel
epoch101 has quit [Ping timeout: 480 seconds]
epoch101 has joined #dri-devel
epoch101_ has quit [Ping timeout: 480 seconds]
alih has joined #dri-devel
airlied_ has joined #dri-devel
bwidawsk has quit [Read error: No route to host]
jstultz has quit [Read error: No route to host]
nicolejadeyee has quit [Read error: No route to host]
lileo has quit [Read error: No route to host]
narmstrong has quit [Read error: No route to host]
linyaa has quit [Read error: No route to host]
mdnavare_ has quit [Read error: Connection reset by peer]
zx2c4 has quit [Read error: No route to host]
jluthra has quit [Read error: No route to host]
hashar has quit [Read error: Connection reset by peer]
steev has quit [Write error: connection closed]
linusw has quit [Read error: Connection reset by peer]
buhman has quit [Write error: connection closed]
ddavenport____ has quit [Read error: No route to host]
hwentlan_ has quit [Write error: connection closed]
jnoorman has quit [Write error: connection closed]
angular_mike_______ has quit [Read error: No route to host]
cheako has quit [Write error: connection closed]
ogabbay has quit [Read error: No route to host]
conchuod has quit [Write error: connection closed]
cengiz_io has quit [Write error: connection closed]
robher has quit [Write error: connection closed]
NishanthMenon has quit [Read error: No route to host]
samuelig has quit [Read error: Connection reset by peer]
seanpaul has quit [Write error: connection closed]
kathleen_ has quit [Write error: connection closed]
markco has quit [Write error: connection closed]
hfink has quit [Read error: No route to host]
CosmicPenguin has quit [Read error: No route to host]
fgcrl has quit [Read error: Connection reset by peer]
_alice has quit [Write error: connection closed]
DemiMarie has quit [Write error: connection closed]
norris has quit [Read error: No route to host]
dianders has quit [Read error: No route to host]
pundir has quit [Read error: Connection reset by peer]
dschuermann has quit [Write error: connection closed]
SanchayanMaity__ has quit [Write error: connection closed]
vgpu-arthur___ has quit [Write error: connection closed]
ernstp has quit [Write error: connection closed]
TimurTabi has quit [Write error: connection closed]
arnd has quit [Read error: No route to host]
MTCoster has quit [Read error: No route to host]
lvrp16_ has quit [Read error: No route to host]
zzag has quit [Read error: No route to host]
tfiga has quit [Read error: No route to host]
krh has quit [Read error: No route to host]
olv has quit [Write error: connection closed]
zzoon has quit [Write error: connection closed]
jimjams has quit [Write error: connection closed]
eric_engestrom has quit [Read error: No route to host]
CosmicPenguin has joined #dri-devel
ddavenport____ has joined #dri-devel
kathleen_ has joined #dri-devel
angular_mike_______ has joined #dri-devel
hwentlan_ has joined #dri-devel
rodrigovivi has quit [Read error: No route to host]
haasn has quit [Read error: No route to host]
ogabbay has joined #dri-devel
mdnavare_ has joined #dri-devel
hashar has joined #dri-devel
hfink has joined #dri-devel
olv has joined #dri-devel
airlied has quit [Ping timeout: 480 seconds]
zzag has joined #dri-devel
TimurTabi has joined #dri-devel
tfiga has joined #dri-devel
zdobersek has quit [Read error: No route to host]
nicolejadeyee has joined #dri-devel
sskras has quit [Read error: Connection reset by peer]
lool has quit [Read error: Connection reset by peer]
buhman has joined #dri-devel
ernstp has joined #dri-devel
lvrp16_ has joined #dri-devel
zmike has quit [Read error: No route to host]
conchuod has joined #dri-devel
austriancoder has quit [Read error: Connection reset by peer]
robclark has quit [Read error: No route to host]
cwabbott has quit [Read error: Connection reset by peer]
linusw has joined #dri-devel
seanpaul has joined #dri-devel
jimjams has joined #dri-devel
norris has joined #dri-devel
zx2c4 has joined #dri-devel
markco has joined #dri-devel
zdobersek has joined #dri-devel
arnd has joined #dri-devel
DemiMarie has joined #dri-devel
lileo has joined #dri-devel
narmstrong has joined #dri-devel
SanchayanMaity__ has joined #dri-devel
haasn has joined #dri-devel
pundir has joined #dri-devel
vgpu-arthur___ has joined #dri-devel
jnoorman has joined #dri-devel
dianders has joined #dri-devel
_alice has joined #dri-devel
lool has joined #dri-devel
samuelig has joined #dri-devel
NishanthMenon has joined #dri-devel
dschuermann has joined #dri-devel
bwidawsk has joined #dri-devel
zzoon has joined #dri-devel
MTCoster has joined #dri-devel
eric_engestrom has joined #dri-devel
krh has joined #dri-devel
zmike has joined #dri-devel
jluthra has joined #dri-devel
robclark has joined #dri-devel
austriancoder has joined #dri-devel
cengiz_io has joined #dri-devel
steev has joined #dri-devel
cwabbott has joined #dri-devel
jstultz has joined #dri-devel
linyaa has joined #dri-devel
sskras has joined #dri-devel
fgcrl has joined #dri-devel
rodrigovivi has joined #dri-devel
cheako has joined #dri-devel
robher has joined #dri-devel
yshui has quit [Ping timeout: 480 seconds]
yshui has joined #dri-devel
Nasina has joined #dri-devel
Nasina has quit [Ping timeout: 480 seconds]
djbw has joined #dri-devel
etehtsea has quit [Ping timeout: 480 seconds]
etehtsea has joined #dri-devel
tzimmermann has quit [Quit: Leaving]
coldfeet has joined #dri-devel
glennk has quit [Read error: Connection reset by peer]
kts has joined #dri-devel
glennk has joined #dri-devel
<demarchi>
jani: however the fix to the nightly.conf assumes people can still fetch drm-rerere
<demarchi>
otherwise they will simply see it block
<jani>
demarchi: true, but same is true for updating maintainer-tools
<demarchi>
yep
<jani>
mmh, okay, some people might have maintainer tools cloned via https
<jani>
but I don't think we can reasonably automate everything
<demarchi>
jani: I think moving all the repos to be via https by default would make sense
<jani>
how does that work with pushing nowadays?
<demarchi>
because 1) it's possible to setup push via https and 2) most people set up the environment before becoming a committer