<logan2611>
GPU doesn't work on -next still, but it looks like now it tries to deference a null pointer for some reason https://0x0.st/KFDe.txt
icecream95 has joined #aarch64-laptops
lynxy has joined #aarch64-laptops
<icecream95>
robclark: I probably should have better explained the bug... the Valgrind report ( https://0x0.st/KUQt.txt ) should make it more clear.
<icecream95>
st_pbo_draw uploads a vertex buffer, then sets constants, then draws using both, but if consts go to a new resource then pipe_upload_constant_buffer0 deletes the resource for the vertex buffer
<icecream95>
Looks like crocus might have a different bug, which may be hard to find without using Valgrind or ASan
<robclark>
try nerfing vbuf, I think that fixes the issue.. I'm a bit suspicious of u_vbuf_set_driver_vertex_buffers() but still digging thru how this is _supposed_ to work post zmike-mr
<robclark>
I know there is some interaction btwn const uploads and streaming uploads.. but don't think that is the root issue
<icecream95>
st_pbo.c uploads the vertex buffer, then calls cso_set_vertex_buffers, which I guess no longer takes a reference to the resource, so the only reference is in the uploader.
<icecream95>
If the uploader is used again before the draw_arrays, then the uploader can release the reference
<icecream95>
I guess that without vbuf, setting vertex buffers goes into the driver and takes a reference there?
_mike_ has joined #aarch64-laptops
<icecream95>
robclark: Oh, and perhaps you can suggest that people debugging run with GALLIUM_THREAD=0, since otherwise threaded_context obscures the stack trace
Caterpillar has quit [Quit: Konversation terminated!]
Caterpillar has joined #aarch64-laptops
krzk has quit [Ping timeout: 480 seconds]
krzk has joined #aarch64-laptops
<McCak[m]>
SpieringsAE: i think it does, but i decided to compile it on my home server under podman ubuntu 25:10, still doesnt work tho as its complain about libssl-dev despite its already installed, weird issue but probably because i was using bindeb-pkg
<McCak[m]>
i am thinking to setup ubuntu vm or just use my oci
<icecream95>
robclark: I think I'm agreeing with you that it isn't the root issue... a bunch of drivers use the uploaders internally, and I think that's why the change doesn't fix crocus
<robclark>
icecream95: rollover of uploader mid-draw seems like a critical thing missed in zmike's changes.. I think maybe tomorrow I'll try undoing the u_uploader part of that commit, since clearly u_uploader needs to hold a ref
<robclark>
yeah, internal driver use is why I was skeptical of splitting uploaders as a "fix"
<icecream95>
robclark: Perhaps the fix is just to use u_upload_alloc_ref for the vertex buffer in st_pbo_draw? (And then set releasebuf to vbo.buffer.resource)
<icecream95>
Then instead of keeping the previous upload buffer alive, we keep the current one alive until the draw, which sounds like a better idea :)
<icecream95>
But I am still confused about exactly what the responsibilities are... perhaps it's actually the const buffer upload's fault for unreferencing the buffer?
mbuhl has quit [Ping timeout: 480 seconds]
mbuhl has joined #aarch64-laptops
bryanodonoghue has quit [Ping timeout: 480 seconds]
bryanodonoghue has joined #aarch64-laptops
<robclark>
I'd kinda prefer that u_upload owns the ref.. when zmike gets back, if he wants to change that it should be accompanied by better docs+debugging ;-)
<robclark>
rather than crossing fingers and hope that u_upload doesn't roll over mid-draw
gwolf has quit [Ping timeout: 480 seconds]
gwolf has joined #aarch64-laptops
jodaco has quit [Ping timeout: 480 seconds]
jodaco has joined #aarch64-laptops
enyalios has quit [Remote host closed the connection]
enyalios has joined #aarch64-laptops
<icecream95>
robclark: Looks like Gallium HUD is broken as well, and so is primconvert, and perhaps the blitter, and user indices, and vbuf, and... so undoing changes for now is probably a good idea
<robclark>
yeah.. I kinda wish there was less stuff stacked on top of that MR, right now reverting is kinda messy.. this kinda sucks
krei-se has joined #aarch64-laptops
<icecream95>
Perhaps u_upload_mgr could keep an array of buffers, and then they all get unreferenced at once at safepoints
krei-se- has quit [Ping timeout: 480 seconds]
<robclark>
I mean, it is all bodging around a fundamentally unsafe change.. the obv right thing to do is revert.. it is just that is messy
<robclark>
but a bit under the weather today.. will take another look after a nights sleep
icecream95 has quit [Quit: rcirc on GNU Emacs 30.2]
_mike_ has quit [Quit: Connection closed for inactivity]
krzk has quit [Ping timeout: 480 seconds]
krzk has joined #aarch64-laptops
tobhe has joined #aarch64-laptops
tobhe_ has quit [Ping timeout: 480 seconds]
zdykstra has quit [Quit: WeeChat 4.7.2]
zdykstra has joined #aarch64-laptops
notHorseface has quit [Quit: I am over the moon, although it is day time so I am probably on the other side of the world, and upside down which would make me the right way up.]
notHorseface has joined #aarch64-laptops
notHorseface has quit [Quit: I am over the moon, although it is day time so I am probably on the other side of the world, and upside down which would make me the right way up.]
notHorseface has joined #aarch64-laptops
notHorseface has quit [Remote host closed the connection]
<steev>
- it occurs with Showtime (the default media player) on the T14s as well, is there any way we could make it less spammy though? i played maybe 15 seconds of the video and have 164K text file from the playback